tbonelee commented on PR #4969:
URL: https://github.com/apache/zeppelin/pull/4969#issuecomment-3072647802
@Reamer
For caution's sake, should we replace this `System.exit(-1)` with
`shutdown(-1)` as well?
```diff
❯❯❯ git diff
diff --git
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
index 8303de4a5..4753babc4 100644
---
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
+++
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
@@ -282,7 +282,7 @@ public class ZeppelinServer implements AutoCloseable {
}
if (!errorDatas.isEmpty()) {
LOGGER.error("{} error(s) while starting - Termination",
errorDatas.size());
- System.exit(-1);
+ shutdown(-1);
}
} catch (InterruptedException e) {
// Many fast unit tests interrupt the Zeppelin server at this point
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
