Reamer commented on code in PR #4973:
URL: https://github.com/apache/zeppelin/pull/4973#discussion_r2212482484
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/display/GUI.java:
##########
@@ -96,7 +96,17 @@ public Object password(String id) {
return params.get(id);
}
+ /**
+ * Create a select form.
+ *
+ * <p>If {@code defaultValue} is a {@link java.util.Collection} the first
+ * element will be used as the actual default value.</p>
+ */
public Object select(String id, ParamOption[] options, Object defaultValue) {
+ if (defaultValue instanceof Collection && !(defaultValue instanceof
String)) {
Review Comment:
```suggestion
if (defaultValue instanceof Collection) {
```
Checking for the string class seems unnecessary to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
