renechoi commented on PR #4977:
URL: https://github.com/apache/zeppelin/pull/4977#issuecomment-3092361873
@Reamer Thank you for the feedback! I've removed all the deprecated methods
as requested.
Regarding the org.eclipse.aether package usage, I investigated the codebase
and found that:
1. The Repository class serves as a bridge between Zeppelin's serializable
repository configuration and Maven Aether's RemoteRepository
2. Key usage points are:
- InterpreterSettingManager: Uses getRepositories() method to convert
Repository to RemoteRepository for dependency resolution
- InterpreterRestApi: Exposes repository information through REST
endpoints
- The conversion methods (toRemoteRepository() and
fromRemoteRepository()) are the main integration points
The current design allows Zeppelin to maintain a clean separation where:
- Internal repository configuration uses our Repository class (JSON
serializable)
- Actual Maven dependency resolution uses Aether's RemoteRepository
I agree that reducing the exposure of org.eclipse.aether classes would
improve the architecture. As you suggested, this could be a good follow-up
improvement after this PR is merged.
@ankursaini2006 Thank you for confirming that these changes should fix the
issue you reported in ZEPPELIN-6231! It's great to hear that this PR will help
resolve the Kubernetes deployment issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
