seung-00 opened a new pull request, #5030:
URL: https://github.com/apache/zeppelin/pull/5030

   ### What is this PR for?
   This PR separates the `isRevisionSupported` field from the configuration API 
into a dedicated endpoint.
   No internal logic is changed.
   * `isRevisionSupported` seems to be more related to Notebook logic rather 
than configuration. It is included in the WebSocket configuration response, 
making the code more complex and less extensible.
   * For example, the REST configuration doesn’t have `isRevisionSupported`. 
Adding it would require injecting a Notebook instance into 
ConfigurationsRestApi, which doesn’t seem related to configurations. It feels 
like a code smell.
   
   ### What type of PR is it?
   Refactoring
   
   ### Todos
   
   ### What is the Jira issue?
   - [ZEPPELIN-6283](https://issues.apache.org/jira/browse/ZEPPELIN-6283)
   
   ### How should this be tested?
   * Run `NotebookTest.testRevisionSupported()`
   * Verify on both New UI and Old UI
   
   ### Questions:
   * Does the license files need to update? N
   * Is there breaking changes for older versions? N
   * Does this needs documentation? N
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to