tbonelee commented on PR #5036:
URL: https://github.com/apache/zeppelin/pull/5036#issuecomment-3208796148
> I plan to run the lint script in CI, so I’d rather not include any fix
there. We already run lint‑staged with fixes locally, which I think should be
sufficient. Would that be okay with you?
Ah, sorry, I think my earlier comment might have been unclear.
I didn't mean adding `--write` to the lint script in CI. I was suggesting
running Prettier with `--write` once on
the existing files so the codebase is already formatted, and then the lint
step would pass cleanly without further fixes. Similar to how you've already
fixed the ESLint errors.
> `@types/webpack-env` is needed to use NodeJS.Require type.
Got it, thanks for confirming!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
