eunhwa99 commented on PR #5033: URL: https://github.com/apache/zeppelin/pull/5033#issuecomment-3210596182
> > LGTM. Thank you. looks simple :-) By the way, is there any reason to make the result as immutable list? > > Immutable objects offer greater security when working with multiple threads on a list. Furthermore, only the NoteManager should be allowed to modify the NoteList. Exactly, that was the idea. 😃 Returning an immutable list prevents unintended side effects with ensuring thread-safety and keeps modification logic centralized in NoteManager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
