renechoi commented on PR #5000:
URL: https://github.com/apache/zeppelin/pull/5000#issuecomment-3214882731
@Reamer I've updated the PR description to reflect the final implementation
after your review feedback.
The description now accurately describes:
- The modernized approach using direct stream capture instead of temporary
files
- Updated test information (removed references to temp file assertions)
- The actual implementation using
`IOUtils.toString(process.getErrorStream(), StandardCharsets.UTF_8)`
I've also resolved the merge conflicts with upstream/master by keeping
both our test and the new tests from upstream.
Thanks for your thorough review and guidance on improving the code
quality! The solution is much cleaner now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
