ParkGyeongTae commented on code in PR #5045:
URL: https://github.com/apache/zeppelin/pull/5045#discussion_r2300815907
##########
zeppelin-web-angular/src/app/pages/workspace/notebook/notebook.component.ts:
##########
@@ -401,7 +403,8 @@ export class NotebookComponent extends
MessageListenersManager implements OnInit
private ticketService: TicketService,
private securityService: SecurityService,
private router: Router,
- protected ngZService: NgZService
+ protected ngZService: NgZService,
+ private titleService: Title
Review Comment:
@dididy @tbonelee
What do you think about unifying the order as `public` → `protected` →
`private` for consistency?
##########
zeppelin-web-angular/src/app/pages/workspace/notebook/notebook.component.ts:
##########
@@ -401,7 +403,8 @@ export class NotebookComponent extends
MessageListenersManager implements OnInit
private ticketService: TicketService,
private securityService: SecurityService,
private router: Router,
- protected ngZService: NgZService
+ protected ngZService: NgZService,
+ private titleService: Title
Review Comment:
@dididy @tbonelee
What do you think about unifying the order as `public` → `protected` →
`private` for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
