dididy opened a new pull request, #5053: URL: https://github.com/apache/zeppelin/pull/5053
### What is this PR for? https://github.com/apache/zeppelin/pull/5045#discussion_r2300816684 Following above PR, I received feedback from a committer suggesting that constructor parameters should be ordered as public → protected → private. I found it deeply but there was no existing TSLint rule for this, So I implemented a custom rule. It works as intended, and I ran lint --fix with the new rule and confirmed that it was applied correctly. The modified files are also included in this PR. If you want to test it just follow below command. ```sh // Base Dir: ./zeppelin/zeppelin-web-angular npm run lint ``` or ```sh // Base Dir: ./zeppelin/zeppelin-web-angular npx tslint -c tslint.json 'src/**/*.ts' --fix ``` You can build the lint rule file using the command below ```sh // Base Dir: ./zeppelin/zeppelin-web-angular/tslint-rules npx tsc constructorParamsOrderRule.ts ``` ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? * [[ZEPPELIN-6301](https://issues.apache.org/jira/browse/ZEPPELIN-6301)] ### How should this be tested? * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? * Is there breaking changes for older versions? * Does this needs documentation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
