pan3793 commented on code in PR #5051:
URL: https://github.com/apache/zeppelin/pull/5051#discussion_r2306258261
##########
bin/common.sh:
##########
@@ -76,12 +76,9 @@ function check_java_version() {
java_ver_output=$("${JAVA:-java}" -version 2>&1)
jvmver=$(echo "$java_ver_output" | grep '[openjdk|java] version' | awk
-F'"' 'NR==1 {print $2}' | cut -d\- -f1)
JVM_VERSION=$(echo "$jvmver"|sed -e 's|^\([0-9][0-9]*\)\..*$|\1|')
- if [ "$JVM_VERSION" = "1" ]; then
- JVM_VERSION=$(echo "$jvmver"|sed -e 's|^1\.\([0-9][0-9]*\)\..*$|\1|')
- fi
- if [ "$JVM_VERSION" -lt 8 ] || { [ "$JVM_VERSION" -eq 8 ] && [
"${jvmver#*_}" -lt 151 ]; } ; then
- echo "Apache Zeppelin requires either Java 8 update 151 or newer"
+ if [ "$JVM_VERSION" -lt 11 ]; then
+ echo "Apache Zeppelin requires either Java 11 or newer"
Review Comment:
it seems to be called by `function getZeppelinVersion`, can you add the
check inside the function instead of `zeppelin-daemon.sh`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
