tbonelee commented on code in PR #5060:
URL: https://github.com/apache/zeppelin/pull/5060#discussion_r2312507043
##########
zeppelin-web-angular/src/app/services/configuration.service.ts:
##########
@@ -13,18 +13,29 @@
import { HttpClient } from '@angular/common/http';
import { Injectable } from '@angular/core';
+import { retry } from 'rxjs/operators';
+import { Configuration } from '../../../projects/zeppelin-sdk/src';
Review Comment:
Could you import this from `@zeppelin/sdk` to align with other import
statements?
##########
zeppelin-web-angular/src/app/share/note-import/note-import.component.ts:
##########
@@ -101,8 +101,8 @@ export class NoteImportComponent extends
MessageListenersManager implements OnIn
}
constructor(
+ private configurationService: ConfigurationService,
Review Comment:
Check this lint error in CI please. (related to #5053)
```
ERROR:
/home/runner/work/zeppelin/zeppelin/zeppelin-web-angular/src/app/share/note-import/note-import.component.ts:103:3
- Constructor parameters should be ordered: public, protected, private
```
##########
zeppelin-web-angular/src/app/share/note-import/note-import.component.ts:
##########
@@ -19,8 +19,8 @@ import { NzUploadFile } from 'ng-zorro-antd/upload';
import { MessageListener, MessageListenersManager } from '@zeppelin/core';
import { MessageReceiveDataTypeMap, OP, SendNote } from '@zeppelin/sdk';
+import { ConfigurationService } from '@zeppelin/services';
Review Comment:
When I ran the app locally, it seems this barrel import may have caused a
circular dependency, which resulted in `ConfigurationService` being undefined.
I initially encountered related errors on the login page.
I am trying to fix overall circular dependencies in #5065, so in here we
could import from the specific paths like below.
```ts
import { ConfigurationService } from
'@zeppelin/services/configuration.service';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
