celinayk commented on code in PR #5063:
URL: https://github.com/apache/zeppelin/pull/5063#discussion_r2321758445
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterInfoSaving.java:
##########
@@ -62,9 +62,10 @@ public static InterpreterInfoSaving loadFromFile(Path file)
throws IOException {
if (infoSaving != null && infoSaving.interpreterSettings != null) {
for (InterpreterSetting interpreterSetting :
infoSaving.interpreterSettings.values()) {
- interpreterSetting.convertPermissionsFromUsersToOwners(
- jsonObject.getAsJsonObject("interpreterSettings")
- .getAsJsonObject(interpreterSetting.getId()));
+ JsonObject interpreterSettingJson =
jsonObject.getAsJsonObject("interpreterSettings")
Review Comment:
> Are you sure this is what is meant by “ugly” here? I think we should use
GSON here to create objects directly.
>
> ```
> GSON.fromJson(json, myFanceClass.class);
> ```
Thank you for the feedback! You're absolutely right. I've refactored the
code to use GSON.fromJson() directly
instead of JsonObject parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
