dididy commented on code in PR #5064: URL: https://github.com/apache/zeppelin/pull/5064#discussion_r2325342495
########## zeppelin-web-angular/src/app/services/shortcut.service.ts: ########## @@ -16,56 +16,59 @@ import { EventManager } from '@angular/platform-browser'; import { Observable } from 'rxjs'; export enum ParagraphActions { - EditMode = 'Paragraph:EditMode', - CommandMode = 'Paragraph:CommandMode', Run = 'Paragraph:Run', + RunAbove = 'Paragraph:RunAbove', RunBelow = 'Paragraph:RunBelow', Cancel = 'Paragraph:Cancel', - Clear = 'Paragraph:Clear', - ReduceWidth = 'Paragraph:ReduceWidth', - IncreaseWidth = 'Paragraph:IncreaseWidth', + MoveCursorUp = 'Paragraph:MoveCursorUp', + MoveCursorDown = 'Paragraph:MoveCursorDown', Delete = 'Paragraph:Delete', - MoveToUp = 'Paragraph:MoveToUp', - MoveToDown = 'Paragraph:MoveToDown', - SelectAbove = 'Paragraph:SelectAbove', - SelectBelow = 'Paragraph:SelectBelow', InsertAbove = 'Paragraph:InsertAbove', InsertBelow = 'Paragraph:InsertBelow', + InsertCopyOfParagraphBelow = 'Paragraph:InsertCopyOfParagraphBelow', + MoveParagraphUp = 'Paragraph:MoveParagraphUp', + MoveParagraphDown = 'Paragraph:MoveParagraphDown', + SwitchEnable = 'Paragraph:SwitchEnable', + SwitchOutputShow = 'Paragraph:SwitchOutputShow', SwitchLineNumber = 'Paragraph:SwitchLineNumber', SwitchTitleShow = 'Paragraph:SwitchTitleShow', - SwitchOutputShow = 'Paragraph:SwitchOutputShow', - SwitchEditorShow = 'Paragraph:SwitchEditorShow', - SwitchEnable = 'Paragraph:SwitchEnable', - Link = 'Paragraph:Link' + Clear = 'Paragraph:Clear', + Link = 'Paragraph:Link', + ReduceWidth = 'Paragraph:ReduceWidth', + IncreaseWidth = 'Paragraph:IncreaseWidth', + FindInCode = 'Paragraph:FindInCode' } export const ShortcutsMap = { Review Comment: 13f201a I’ve added it. ########## zeppelin-web-angular/src/app/pages/workspace/notebook/paragraph/code-editor/code-editor.component.ts: ########## Review Comment: 2f5838f I’ve added it. Thanks for always giving such helpful reviews. I’ll make sure to reflect any other feedback if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org