dididy commented on PR #5074: URL: https://github.com/apache/zeppelin/pull/5074#issuecomment-3292610192
I didn’t realize there could be such an edge case. From a quick look, I now understand that Angular allows calling constructors dynamically in that way, and in such cases, the order of the parameters must match the order in the constructor. From my quick review, it seems that there are no side effects from the changes I made that are similar to the issue caused here by my changes. But just to be safe, I’ll take a closer look. One thing I’m curious about: I understand that `visualizationItem.componentFactoryResolver` was removed because it’s no longer needed in Angular 9. Is that correct? It looks like it’s still being used in **visualization-component-portal.ts** and **json-visualization.ts**, and based on my review, that’s probably because the project is still using Angular 8. I was wondering if there’s a plan to upgrade to Angular 9, and if not, what challenges are preventing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
