dididy commented on code in PR #5075:
URL: https://github.com/apache/zeppelin/pull/5075#discussion_r2355488176
##########
zeppelin-web-angular/src/app/visualizations/table/table-visualization.component.ts:
##########
@@ -96,11 +89,8 @@ export class TableVisualizationComponent implements OnInit {
this.filterRows();
}
- onSortChange(type: 'descend' | 'ascend' | string, key: string): void {
- const opt = this.colOptions.get(key);
- if (!opt) {
- throw new Error('opt is not found');
- }
+ onSortChange(type: 'descend' | 'ascend' | string | null, key: string): void {
Review Comment:
I thought it was possible to share a link to a specific line in the commit,
but it seems that’s not the case. I’ve updated the link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
