tbonelee commented on code in PR #5065:
URL: https://github.com/apache/zeppelin/pull/5065#discussion_r2330400440
##########
zeppelin-web-angular/src/app/pages/workspace/workspace.component.ts:
##########
@@ -11,11 +11,11 @@
*/
import { ChangeDetectionStrategy, ChangeDetectorRef, Component, HostListener,
OnDestroy, OnInit } from '@angular/core';
-import { isRecord } from '@zeppelin/utility/type-utility';
+import { publishedSymbol } from '@zeppelin/core';
+import { isRecord } from '@zeppelin/utility';
import { Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators';
-import { publishedSymbol } from '@zeppelin/core/paragraph-base/published';
import { HeliumManagerService } from '@zeppelin/helium-manager';
import { MessageService } from '@zeppelin/services';
import { setTheme } from '@zeppelin/visualizations/g2.config';
Review Comment:
Thanks for pointing out the missing parts! I cherry-picked your commit and
made some modifications.
Since the newly added elements in the `VisualizationModule` declarations
were neither Angular components, directives, nor pipes, I reverted those. If I
still missed anything, please feel free to let me know.
I also agree that the similarity in naming could cause some confusion. We
might consider further refactoring in later PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
