tbonelee opened a new pull request, #5081:
URL: https://github.com/apache/zeppelin/pull/5081

   ### What is this PR for?
   Tests in the `zeppelin-zengine` module were failing. The main reason was 
that the `interpreter.json` in test resources were invalid: the value object 
did not have an `id` field matching its corresponding key.
   As a result, the deserialized `InterpreterSetting` instance had an 
auto-genarated `id` field, causing the key and value.id to be inconsistent.
   Before #5063, invalid settings were simply skipped. However, after that 
change, they caused a NPE.
   
   This PR fixes the invalid JSON files and adds minor validation logic in the 
deserialization method so that such issues can be detected early by users.
   
   ### What type of PR is it?
   Bug Fix
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-6335
   
   ### How should this be tested?
   * Check `core-modules` - `zeppelin-zengine` tests in CI
   
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to