grcenneat commented on code in PR #5079:
URL: https://github.com/apache/zeppelin/pull/5079#discussion_r2376193162
##########
zeppelin-web-angular/src/app/pages/workspace/notebook/action-bar/action-bar.component.html:
##########
@@ -177,9 +177,41 @@
</nz-dropdown-menu>
</nz-button-group>
<nz-button-group nzSize="small">
- <button nz-button nz-tooltip nzTooltipTitle="Search code"
(click)="searchCode()">
+ <button
+ nz-button
+ nz-dropdown
+ [nzDropdownMenu]="searchMenu"
+ nzTrigger="click"
+ nz-tooltip
+ nzTooltipTitle="Search code"
+ nzTooltipTrigger="hover"
+ (nzVisibleChange)="onSearchMenuOpenChange($event)"
+ >
<i nz-icon nzType="search" nzTheme="outline"></i>
</button>
+ <!-- Search Code Dropdown UI -->
+ <nz-dropdown-menu #searchMenu="nzDropdownMenu">
+ <div class="ant-dropdown-menu">
+ <div style="display: flex;">
+ <nz-input-group nzAddOnBefore="Find">
+ <input type="text" nz-input [(ngModel)]="searchText"
(ngModelChange)="searchCode()" />
+ </nz-input-group>
+ <nz-button-group style="display: flex; align-items: center;
flex-wrap: nowrap;">
+ <button nz-button (click)="onFindPrevClick(searchText)"><i
nz-icon nzType="left"></i></button>
+ <button nz-button (click)="onFindNextClick(searchText)"><i
nz-icon nzType="right"></i></button>
+ </nz-button-group>
Review Comment:
@dididy
I guess that’s a really good suggestion. While developing the feature to
display the number of search results in the `n of m` format, I’ll also make
sure to include this functionality.
I followed your advice and removed the white background in the margin,
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
