dididy commented on code in PR #5092:
URL: https://github.com/apache/zeppelin/pull/5092#discussion_r2403644801
##########
zeppelin-web-angular/src/app/share/note-import/note-import.component.ts:
##########
@@ -92,7 +92,7 @@ export class NoteImportComponent extends
MessageListenersManager implements OnIn
// @ts-ignore
result.name = this.noteImportName;
}
- this.messageService.importNote(result as SendNote);
+ this.messageService.importNote(result as ImportNote['note']);
Review Comment:
Contextually, that makes sense — the multiple conditions in the method are
probably there to validate that `data` has the correct shape. I left that
comment on impulse because the `ts-ignore` caught my eye, but it doesn’t really
seem like something that needs to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
