tbonelee commented on PR #5095: URL: https://github.com/apache/zeppelin/pull/5095#issuecomment-3406844666
On the official site, the only reference I could find is the Javadoc link for the type used by the `<relocations>` property (https://maven.apache.org/components/plugins/maven-shade-plugin/apidocs/org/apache/maven/plugins/shade/relocation/SimpleRelocator.html), which doesn’t provide much detail. I skimmed the code and initially assumed rawString was an option to exclude string literals in .java files from being shaded (https://github.com/apache/maven-shade-plugin/blob/073e7ca970c15a8cae64e2de9517fe8d471b5373/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java#L217). I only tried the rawString option to quickly check whether our test failures were caused by shading string literals in java code, so I didn’t investigate it more rigorously. However, looking at the issue where this option was introduced (https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-104?filter=allissues) and re-read the whole code of `SimpleRelocator`, the primary intent seems to be treating patterns as regex. If that’s the case, a pattern like `com.google` would be interpreted as a regex, which could lead to unexpected relocations. I’ve struck through my earlier explanation about `rawString` since it was inaccurate. Sorry about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
