dididy commented on PR #5080: URL: https://github.com/apache/zeppelin/pull/5080#issuecomment-3351632949
I haven’t thought too deeply about this before, but the approach you mentioned seems reasonable. I looked through Zeppelin to see if there were similar cases of using comments like this, but I couldn’t find any. Usually, I place comments immediately above the relevant code, which I think works fine because it maintains consistency for anyone reading the code. However, varying the position of comments based on their purpose could help emphasize different points. (Actually, the part I intended to modify was the TODO comment about `as const` in `/notebook-paragraph-keyboard-event-handler.ts`.) Could you add an e2e test for the keyboard shortcuts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
