tbonelee commented on code in PR #5128:
URL: https://github.com/apache/zeppelin/pull/5128#discussion_r2597149197
##########
.github/workflows/frontend.yml:
##########
@@ -93,15 +95,37 @@ jobs:
key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-zeppelin-
+ - name: Setup conda environment with python ${{ matrix.python }}
+ uses: conda-incubator/setup-miniconda@v3
+ with:
+ activate-environment: python_only
+ python-version: ${{ matrix.python }}
+ auto-activate-base: false
+ use-mamba: true
+ channels: conda-forge,defaults
+ channel-priority: strict
- name: Install application
- run: ./mvnw clean install -DskipTests -am -pl zeppelin-web-angular
${MAVEN_ARGS}
+ run: ./mvnw clean install -DskipTests -am -pl
python,rlang,zeppelin-jupyter-interpreter,zeppelin-web-angular ${MAVEN_ARGS}
- name: Setup Zeppelin Server (Shiro.ini)
run: |
export ZEPPELIN_CONF_DIR=./conf
if [ "${{ matrix.mode }}" != "anonymous" ]; then
cp conf/shiro.ini.template conf/shiro.ini
sed -i 's/user1 = password2, role1, role2/user1 = password2,
role1, role2, admin/' conf/shiro.ini
fi
+ - name: Setup Zeppelin Configuration (Disable Git)
+ run: |
+ # Copy zeppelin-site.xml template
+ cp conf/zeppelin-site.xml.template conf/zeppelin-site.xml
+ # Replace GitNotebookRepo with VFSNotebookRepo to avoid Git issues
in E2E tests
+ sed -i
's/org.apache.zeppelin.notebook.repo.GitNotebookRepo/org.apache.zeppelin.notebook.repo.VFSNotebookRepo/g'
conf/zeppelin-site.xml
+ echo "--- Notebook storage configuration ---"
+ grep -A 2 "zeppelin.notebook.storage" conf/zeppelin-site.xml | head
-6
+ echo "---------------------------------------"
Review Comment:
If we only need to modify `zeppelin.notebook.storage` configuration, how
about setting `ZEPPELIN_NOTEBOOK_STORAGE` environment variable in this job
instead?
This way, we can remove the complicated `zeppelin-site.xml` copying steps
and avoid introducing uncontrolled configurations in `zeppelin-site.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
