seung-00 commented on code in PR #5167:
URL: https://github.com/apache/zeppelin/pull/5167#discussion_r2934546882
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java:
##########
@@ -144,7 +143,7 @@ public class RemoteInterpreterServer extends Thread
// pod (RemoteInterpreterServer)
private boolean isForceShutdown = true;
- private ZeppelinConfiguration zConf;
+ private Properties zProperties;
Review Comment:
How about introducing a DTO class within the interpreter module for type
safety?
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/dep/Booter.java:
##########
@@ -83,10 +82,10 @@ static String resolveLocalRepoPath(String localRepoPath) {
}
public static List<RemoteRepository> newCentralRepositorys(Proxy proxy,
- ZeppelinConfiguration zConf) {
+ String mvnRepoUrl) {
String mvnRepoEnv = System.getenv("ZEPPELIN_INTERPRETER_DEP_MVNREPO");
if (mvnRepoEnv == null) {
- mvnRepoEnv =
zConf.getString(ZeppelinConfiguration.ConfVars.ZEPPELIN_INTERPRETER_DEP_MVNREPO);
+ mvnRepoEnv = mvnRepoUrl;
}
if (mvnRepoEnv == null) {
mvnRepoEnv = "https://repo1.maven.org/maven2/";;
Review Comment:
nit: This part is a bit hard for me to read due to multiple re-assignments.
Would it be better to use a more explicit pattern to clarify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
