tbonelee opened a new pull request, #5258: URL: https://github.com/apache/zeppelin/pull/5258
### What is this PR for? `zeppelin-react` has its own ESLint config with rules at `error` level (e.g. `@typescript-eslint/no-explicit-any`, `react-hooks/exhaustive-deps`), but its lint script is not wired into the root `npm run lint` of `zeppelin-web-angular`. As a result, Maven's `npm lint` execution (`zeppelin-web-angular/pom.xml`) does not catch ESLint violations in `zeppelin-react`. ### What changes are proposed? Mirror the existing `build:react` pattern with `lint:react` / `lint:fix:react` scripts and include them in the root composite `lint` and `lint:fix` scripts. The `postinstall` hook already installs `projects/zeppelin-react/node_modules`, so no extra install step is needed. ### What type of PR is it? Improvement ### Todos * [x] - Update root lint scripts to include zeppelin-react ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6421 ### How should this be tested? Run `npm run lint` inside `zeppelin-web-angular/` and confirm that zeppelin-react ESLint errors are reported. ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
