voidmatcha commented on code in PR #5264:
URL: https://github.com/apache/zeppelin/pull/5264#discussion_r3356481181
##########
zeppelin-web-angular/src/app/core/message-listener/message-listener.ts:
##########
@@ -43,18 +42,15 @@ export function MessageListener<K extends keyof
MessageReceiveDataTypeMap>(op: K
) {
const oldValue = descriptor.value as ReceiveArgumentsType<K>;
- // eslint-disable-next-line no-invalid-this
const fn = function (this: MessageListenersManager) {
- // eslint-disable-next-line no-invalid-this
if (!this.__zeppelinMessageListeners$__) {
throw new Error('__zeppelinMessageListeners$__ is not defined');
}
- // eslint-disable-next-line no-invalid-this
+
this.__zeppelinMessageListeners$__.add(
- // eslint-disable-next-line no-invalid-this
this.messageService.receive(op).subscribe(data => {
// @ts-ignore
- // eslint-disable-next-line no-invalid-this
+
Review Comment:
```suggestion
```
Suggestion: blank lines left behind where comments were deleted (here and
below `// @ts-ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
