Copilot commented on code in PR #59: URL: https://github.com/apache/zeppelin-site/pull/59#discussion_r3366321847
########## docs/0.12.0/Gemfile: ########## @@ -17,7 +17,7 @@ source 'https://rubygems.org' gem 'github-pages' gem 'redcarpet' gem 'jekyll-twitter-plugin' -gem 'nokogiri', '1.15.4' +gem 'nokogiri', '1.19.3' gem 'mini_portile2', '2.8.4' Review Comment: The PR description says `docs/0.12.0` should be “lockfile only”, but this change updates `docs/0.12.0/Gemfile` as well (pins `nokogiri` to 1.19.3). Either update the PR description to reflect that the Gemfile is intentionally changed, or revert this Gemfile change (and the corresponding lockfile bump) if the intent is truly lockfile-only for already-published docs. ########## Dockerfile: ########## @@ -1,5 +1,5 @@ # Use the latest official Ruby runtime as a parent image -FROM ruby:3.0.6 +FROM ruby:3.3.5 Review Comment: `Gemfile.lock` was generated with Bundler 4.0.13, but the Docker image installs an unpinned Bundler (`gem install bundler`). This makes the Docker build non-reproducible and can fail if a future Bundler release is incompatible or if the installed Bundler version is < 4 (which would refuse this lockfile). Pin the Bundler version used in the image to the lockfile’s `BUNDLED WITH` version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
