pan3793 commented on code in PR #5271:
URL: https://github.com/apache/zeppelin/pull/5271#discussion_r3530671152
##########
zeppelin-server/src/main/java/org/apache/zeppelin/notebook/Paragraph.java:
##########
@@ -314,7 +314,7 @@ public boolean shouldSkipRunParagraph() {
boolean checkEmptyConfig =
(Boolean)
config.getOrDefault(InterpreterSetting.PARAGRAPH_CONFIG_CHECK_EMTPY, true);
// don't skip paragraph when local properties is not empty.
- // local properties can customize the behavior of interpreter. e.g.
%r.shiny(type=run)
+ // local properties can customize the behavior of interpreter. e.g.
%flink.ssql(type=update)
Review Comment:
Changed to `%spark(pool=pool1)` — this is a real, documented Spark local
property (Spark scheduler pool, documented in
`docs/interpreter/spark.md:428-431`). It's the most contextually appropriate
replacement: it's a Spark example (not Flink), the syntax is valid, and the
local property is meaningful for Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
