kimyenac opened a new pull request, #5291: URL: https://github.com/apache/zeppelin/pull/5291
### What is this PR for? In the interpreter "add repository" dialog, the proxy **Password** input was bound to the wrong reactive-form control (`proxyLogin`) — the same control the **Login** field already uses. As a result a proxy password could never be saved, and typing a proxy password overwrote the proxy login. This PR binds the Password input to the `proxyPassword` control so that both proxy credentials are submitted independently. `create-repository-modal.component.html`: ```diff - <input nz-input type="password" formControlName="proxyLogin" placeholder="proxy password" /> + <input nz-input type="password" formControlName="proxyPassword" placeholder="proxy password" /> ``` ### What type of PR is it? Bug Fix ### Todos * [x] - Fix the form-control binding * [x] - Add an e2e regression test ### What is the ticket? https://issues.apache.org/jira/browse/ZEPPELIN-6520 ### How should this be tested? * `cd zeppelin-web-angular && npm run lint` * A Playwright e2e test is added: `e2e/tests/workspace/interpreter/create-repository-proxy-credentials.spec.ts`. It fills the proxy login and proxy password in the add-repository modal and asserts the `POST /api/interpreter/repository` payload carries each value in its own field (`proxyLogin` / `proxyPassword`). The test fails on the current binding and passes with this fix. * Manually: add a repository with a proxy login and password in the interpreter UI and confirm both are sent. ### Screenshots (if appropriate) N/A — the form renders identically; the defect is only visible in the submitted payload. ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
