miridih-ynkim commented on PR #5305:
URL: https://github.com/apache/zeppelin/pull/5305#issuecomment-4988262427
Thanks for the review, @voidmatcha. Good point — extended the cleanup to the
remaining `substr()` in `angular-drag-drop.service.ts` in the latest commit.
Cached `indexOf('.')` in a local and used `slice(0, dotIndex)`, which keeps the
same behavior including the `null` branch when there's no dot. Verified with
`npm run lint`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
