tbonelee commented on PR #5308:
URL: https://github.com/apache/zeppelin/pull/5308#issuecomment-4995089232

   One thing worth weighing before wiring it back up: that `<version>` 
reference wasn't just never added, it was removed on purpose in #4884 
([ZEPPELIN-6138] Update Apache Parent), which un-pinned ~10 plugins at once to 
defer their versions to the parent pom. It just left the 
`plugin.checkstyle.version` property behind as leftover cruft.
   
   So re-pinning would special-case checkstyle away from the parent-managed 
version, while the other plugins from that commit stay parent-managed. Unless 
there's a concrete reason to need `3.6.0`, would just deleting the orphaned 
property fit the ticket's intent better? Curious what you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to