miinhho opened a new pull request, #5317: URL: https://github.com/apache/zeppelin/pull/5317
### What is this PR for? This PR separates the classic UI Playwright e2e suite from the main Playwright config. After ZEPPELIN-6527, classic specs under `e2e/tests/classic/` were wired into the shared config and gated with `E2E_CLASSIC` plus argv sniffing. That made plain `npm run e2e` depend on a `-Pweb-classic` server, allowed false positives from arguments like `--grep tests/classic`, and caused the coverage reporter to run for classic pages that are outside the coverage denominator. This change moves classic execution to a dedicated `playwright.classic.config.js`, updates `e2e:classic` and CI wiring to use it, removes the env/argv detection from the main config, and keeps the coverage reporter on the main suite only. ### What type of PR is it? Improvement ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-6545 ### How should this be tested? - `cd zeppelin-web-angular && npm run e2e -- tests/classic --list --reporter=list` - Verifies the main Playwright config no longer selects classic specs. - `cd zeppelin-web-angular && npm run e2e:classic -- --list --reporter=list` - Verifies classic specs are selected only through the dedicated classic config. - `rg "E2E_CLASSIC|process\\.argv|isClassicOnlyRun|E2E_MODE" zeppelin-web-angular .github/workflows/frontend.yml` - Verifies the old env/argv gating was removed. - `rg "reporter\\.coverage" zeppelin-web-angular/playwright.config.js zeppelin-web-angular/playwright.classic.config.js` - Verifies the coverage reporter is only configured for the main suite. ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? Edit AGENTS.md about modified classic suite config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
