tbonelee commented on PR #5314: URL: https://github.com/apache/zeppelin/pull/5314#issuecomment-5012132052
Since the PR's goal is to make `IndexHtmlServletTest` independent of the frontend build, could we apply the same treatment to `testZeppelinWebHtmlAddon` in this PR? It still hardcodes `../zeppelin-web/dist/index.html`, another git-ignored build artifact. It only passes in CI because the core job builds `zeppelin-web` via `-Pweb-classic`; a clean local `./mvnw test -pl zeppelin-server` would fail it for the exact reason you're fixing on the Angular side. Reusing the `@TempDir` pattern here (with a document that omits the closing tags, so it exercises the fallback branch in `IndexHtmlServlet`) would make both tests fully self-contained and complete the stated goal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
