kimyenac commented on PR #5313: URL: https://github.com/apache/zeppelin/pull/5313#issuecomment-5014686007
@tbonelee Thanks for the review! You're right. I was following the issue's premise that the table array "doesn't drive any display," but `table-visualization.component.html:112` renders it as the Aggregation dropdown — so a shared canonical order would have silently reordered it (Count, Sum, Min, Max, Avg → Sum, Count, Avg, Min, Max). Fixed by sharing the type only. `aggregation-type.ts` now exports just `AggregationType`, and each component keeps its own order array typed `readonly AggregationType[]`. This drops the untyped `string[]`, keeps the table's `switch` exhaustive, and leaves both dropdowns unchanged. I've also updated the description and extended the manual check to the table dropdown. Force-pushed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
