kimyenac opened a new pull request, #5323:
URL: https://github.com/apache/zeppelin/pull/5323

   ### What is this PR for?
   The Angular UI now uses TypeScript ~5.9.3, so the pre-4.9 workaround TODOs 
that asked to replace broad type assertions with `satisfies` are obsolete. This 
replaces those outdated assertions with `satisfies`, which improves 
compile-time checking without changing runtime behavior.
   
   - `app.module.ts`: `as JoinedEditorOptions` → `satisfies 
JoinedEditorOptions`, so unsupported editor options are caught at compile time.
   - `create-repository-modal.component.ts`: `as Record<...>` → `satisfies 
Record<...>`, so every form control key is validated against 
`CreateInterpreterRepositoryForm`.
   - `notebook-paragraph-keyboard-event-handler.ts`: `as const` → `as const 
satisfies ...` for both the action→handler map and the Monaco-handled action 
list. `as const` is intentionally kept so the downstream `typeof`-based literal 
indexing still narrows correctly, while `satisfies` now validates keys/values 
(e.g. invalid handler names are rejected).
   
   All three changes are compile-time-only annotations; runtime behavior is 
unchanged.
   
   ### What type of PR is it?
   Improvement
   
   ### What is the Jira issue?
   [ZEPPELIN-6441](https://issues.apache.org/jira/browse/ZEPPELIN-6441)
   
   ### How should this be tested?
   - `cd zeppelin-web-angular && npm run lint` passes (0 errors).
   - Verified the `satisfies` checks are active: injecting an unsupported 
editor option is caught as TS2353, and an invalid handler name is caught as 
TS2418.
   
   ### Questions:
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this need documentation? No
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to