JangAyeon commented on code in PR #5320:
URL: https://github.com/apache/zeppelin/pull/5320#discussion_r3610101070
##########
zeppelin-web-angular/src/app/visualizations/table/table-visualization.component.ts:
##########
@@ -209,7 +209,7 @@ export class TableVisualizationComponent implements OnInit {
sortTypes.push(value.sort);
}
// eslint-disable-next-line @typescript-eslint/no-explicit-any
- terms.push((row: any) => String(row[key]).search(value.term) !== -1);
+ terms.push((row: any) => String(row[key]).includes(value.term.trim()));
Review Comment:
Good catch, fixed — hoisted value.term.trim() out of the per-row predicate
in a9e20e78b.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
