Hello Eric, others,
Sorry to comment on a very old thread.
On 2025-09-18 11:43, Eric Rescorla wrote:
On Wed, Sep 17, 2025 at 7:27 PM Paul Hoffman <[email protected]> wrote:
I ask because I suck at commenting in PRs for documents, and when I do so,
I get wildly different advice from the authors about the proper way to
comment in a PR. It would be good if the RPC could say to authors ahead of
time how the authors should interact with the PR (just as they are told how
to respond to AUTH48 email).
Well, hopefully this situation is clearer because the space of reasonable
comments is rather smaller, as the authors should only be commenting on
text the RPC has changed, and so mostly you should either be saying "Please
revert this change" or "Here is yet another alternate piece of text".
For simple reversal or approval, and for longer actual comments (e.g.
"Thanks for catching this." or "Don't forget to apply this change
throughout the document." or so), that works fine.
Just to be clear, if the authors want to make unsolicited changes beyond
what the RPC changed, they should be generating their own PRs, not making
those changes to the RPC's PR.
If they want to make changes to other pieces of the document (e.g. to
address issues that haven't been dealt with before), that makes sense.
But for tweaks to the edits from the RPC, commits on top of the RPC's
commits would make the most sense. The main point of using git/github
here is to have a mechanically applicable description of the desired
changes. Separate comments may be needed to explain the reason for the
desired changes, but using comments to describe the changes themselves
in textual form should be a thing of the past if we move to git/github.
As mostly a separate issue, please also note that there are some people
(me not included; don't know how many of the active IETF participants)
that have no problem using git, but do not want to use github because
they have an aversion to using non-open-source software or JavaScript or
whatever. We always have the old OLD/NEW email system as a backup, but
it would be great if we could set up the git/github workflow in a way
that would allow such people to use it too, even if only partially.
Regards, Martin.
_______________________________________________
rfc-interest mailing list -- [email protected]
To unsubscribe send an email to [email protected]
