Regarding that, since this ritual has repeated several times, what about becoming a committer? Cool. I'd certainly like that.
On Sat, Jan 10, 2009 at 10:51 AM, Ayende Rahien <[email protected]> wrote: > I can't think of a single reason why this is the case.Disallowing the > change of an operation name? sure. > This? I can't figure out what I was thinking, thus, it is useless. > Please make the change. > > Regarding that, since this ritual has repeated several times, what about > becoming a committer? > > > On Sat, Jan 10, 2009 at 11:45 AM, Bart Reyserhove < > [email protected]> wrote: > >> Yeah I know, that's what I tried to explain yesterday. I just cannot think >> of a reason why we would want this. There is even a test case for it that >> tests that you cannot change the name. >> Do I change it and the test as well? >> >> >> On Fri, Jan 9, 2009 at 11:25 PM, Ayende Rahien <[email protected]> wrote: >> >>> Took me a LONG time to figure out what is going on. >>> Check the mapping: >>> >>> <property name="Name" >>> access="property" >>> type="String" >>> update="false"> >>> <column name="Name" >>> length="255" >>> not-null="true" >>> unique="true"/> >>> </property> >>> >>> Can you think of any reason why we would want this to be the case? >>> >>> >>> On Fri, Jan 9, 2009 at 3:39 PM, Bart Reyserhove < >>> [email protected]> wrote: >>> >>>> Sorry, I meant UsersGroup but it is also the case for EntitiesGroup, so >>>> it definitely has a reason ;-) >>>> >>>> >>>> On Fri, Jan 9, 2009 at 2:32 PM, Bart Reyserhove < >>>> [email protected]> wrote: >>>> >>>>> I checked the EntitiesGroup mapping file and apparently the property >>>>> Name has an attribute "update=false". Why is that? >>>>> >>>>> >>>>> On Thu, Jan 8, 2009 at 10:14 AM, Bart Reyserhove < >>>>> [email protected]> wrote: >>>>> >>>>>> Attached a patch with a test case that fails. >>>>>> >>>>>> >>>>>> On Thu, Jan 8, 2009 at 9:10 AM, Ayende Rahien <[email protected]>wrote: >>>>>> >>>>>>> Hm... >>>>>>> Can you create a small test case for this? >>>>>>> >>>>>>> >>>>>>> On Thu, Jan 8, 2009 at 10:03 AM, Bart Reyserhove < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Yep, I changed the name of the usersgroup. >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Jan 8, 2009 at 6:27 AM, Ayende Rahien <[email protected]>wrote: >>>>>>>> >>>>>>>>> Are you updating any of the fields to a new value? >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Jan 8, 2009 at 12:44 AM, Bart Reyserhove < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Ok, I tried to figure out this one myself but it's probably too >>>>>>>>>> late in the evening and I'm probably overlooking something stupid. In >>>>>>>>>> Rhino.Security there are UsersGroup and I want to change the name of >>>>>>>>>> one of >>>>>>>>>> those. >>>>>>>>>> I have a very small edit page to do that which posts to the >>>>>>>>>> following controller method: >>>>>>>>>> >>>>>>>>>> [SecuredOperation("Edit")] >>>>>>>>>> public virtual ActionResult Update(Guid id) >>>>>>>>>> { >>>>>>>>>> var usersGroup = _userGroupService.Get(id); >>>>>>>>>> SmartBinder.UpdateFrom(usersGroup, Request.Form); >>>>>>>>>> try >>>>>>>>>> { >>>>>>>>>> _userGroupService.Save(usersGroup); >>>>>>>>>> } >>>>>>>>>> catch (ValidationException e) >>>>>>>>>> { >>>>>>>>>> TempData["errors"] = >>>>>>>>>> e.Summary.GetLocalizedErrorMessages(); >>>>>>>>>> return View("New", >>>>>>>>>> BuildViewData(usersGroup).WithTitle(Resources.User.NewTitle)); >>>>>>>>>> } >>>>>>>>>> return this.RedirectToAction(c => c.List()); >>>>>>>>>> } >>>>>>>>>> >>>>>>>>>> The 'Save' method from the _userGroupService is called with the >>>>>>>>>> updated usersGroup. I checked that and it is indeed changed there. >>>>>>>>>> The very fancy 'Save' method looks like this: >>>>>>>>>> >>>>>>>>>> [Transaction] >>>>>>>>>> public virtual void Save(UsersGroup instance) >>>>>>>>>> { >>>>>>>>>> _userGroupRepos.SaveOrUpdate(instance); >>>>>>>>>> } >>>>>>>>>> >>>>>>>>>> In NhProf I see that a transaction is started and committed but >>>>>>>>>> there is nothing done in the transaction. The UsersGroup is using >>>>>>>>>> the second >>>>>>>>>> level cache, so maybe it has something to do with that but I'm not >>>>>>>>>> sure. >>>>>>>>>> >>>>>>>>>> If anyone can shed some light on this one, that would be most >>>>>>>>>> welcome ;-) >>>>>>>>>> >>>>>>>>>> Greetz, >>>>>>>>>> >>>>>>>>>> Bart >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> >>>> >>> >>> >>> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Rhino Tools Dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/rhino-tools-dev?hl=en -~----------~----~----~----~------~----~------~--~---
