I wouldn't know how to fix that. I'd expect an integer and a byte both with value 1 to compare as equal, but once they're boxed, how do you compare them?BTW, sorry to make you patch again, but here's another one which handles null values correctly.
On Tue, Jan 20, 2009 at 4:01 PM, Ayende Rahien <[email protected]> wrote: > should this behavior be by design? > > > On Tue, Jan 20, 2009 at 2:33 AM, Simone Busoli <[email protected]>wrote: > >> I think that column names should not be compared taking casing into >> account, here's a fix for the previous patch, with tests. And another >> test about something which caused me some pain. Since row values are boxed, >> calling equals on them calls the Object.Equals instance method virtually, >> using the Equals(Object) overload. Because of this, this call returns false: >> >> ((Object)1).Equals((Byte)1) >> >> which is a somewhat unexpected behavior. The test shows that this behavior >> is.. by design. >> >> >> On Mon, Jan 19, 2009 at 2:39 AM, Ayende Rahien <[email protected]> wrote: >> >>> Applied, thanks. >>> >>> On Sun, Jan 18, 2009 at 4:42 PM, Simone Busoli >>> <[email protected]>wrote: >>> >>>> And here's a patch which lets compare rows based on their contents. I >>>> needed this in the context of mirroring tables to verify if a row coming >>>> from a join on the ID had to be updated or if it was unchanged. >>>> >>>> >>> >>> >>> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Rhino Tools Dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/rhino-tools-dev?hl=en -~----------~----~----~----~------~----~------~--~---
NullHandling.patch
Description: Binary data
