I made a comment about your pull request and you replied to it, but never changed what we talked about in the comments.
On Fri, May 6, 2011 at 3:45 AM, vandalo <alberto.bas...@gmail.com> wrote: > I don't understand who's managing this project. I've pulled a request > and submitted some changes (with test-case as required) but it's just > on my account. > Nobody replied or bothered to apply these changes. > Now I was looking at RemCoros repository and found out that he made > some changes but they do exist only in it's project. > > Alberto > > On Apr 22, 11:33 am, Nathan Stott <nrst...@gmail.com> wrote: >> Can you send a pull request? The only recent pull request I've >> received is this >> one:https://github.com/vandalo/rhino-security/commit/0795e30ee8b7dd8651ad... >> >> >> >> >> >> >> >> On Fri, Apr 22, 2011 at 2:31 AM, Remco Ros <r....@rawsoft.nl> wrote: >> > Hi Rick, >> >> > I have never used rhino-security, so I can't be 100% sure about the >> > rammification. But as far as I can see the only place where data access >> > code >> > lives is in that repository. >> >> > There are two options: >> > - evict the whole query cache after each change (this has some performance >> > implications when you're doing a lot of updates/reads at the same time, >> > because after each update the whole query cache is evicted) >> > - split the queries in different cache regions (using SetCacheRegion) and >> > evict that regions query cache whenever an update occurs which should >> > invalidate that region. >> >> > If you can write the failing tests, I can implement selective query >> > eviction >> > like I did for the first test you wrote. >> > (https://github.com/remcoros/rhino-security) >> >> > Also maybe Nathan can have a look at this? >> >> > Remco >> >> > -- >> > You received this message because you are subscribed to the Google Groups >> > "Rhino Tools Dev" group. >> > To post to this group, send email to rhino-tools-dev@googlegroups.com. >> > To unsubscribe from this group, send email to >> > rhino-tools-dev+unsubscr...@googlegroups.com. >> > For more options, visit this group at >> >http://groups.google.com/group/rhino-tools-dev?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "Rhino Tools Dev" group. > To post to this group, send email to rhino-tools-dev@googlegroups.com. > To unsubscribe from this group, send email to > rhino-tools-dev+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rhino-tools-dev?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Rhino Tools Dev" group. To post to this group, send email to rhino-tools-dev@googlegroups.com. To unsubscribe from this group, send email to rhino-tools-dev+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rhino-tools-dev?hl=en.