I would like to pull these in. However, can you have a look at the contribution guidelines linked below and then submit a pull request.
http://hibernatingrhinos.com/open-source/rhino-service-bus/how-to-contribute On Tue, Jul 24, 2012 at 4:26 PM, miles <[email protected]> wrote: > Hi, > > Ok, so I adjusted queues and esb to work in the same way as Caliburn, and > it's all working fine for me in production for a while now: the changes > were far smaller than my need to get it working! > > So,I've made a fork with the changes hoping that the change is still > acceptable, and I can submit a pull request for it shortly. The forks are > here: > > https://github.com/mr-miles/rhino-queues > https://github.com/mr-miles/rhino-esb > > What's the best way to package things up to retain some backwards > compatibilitty? In particular, the new implementation does no logging > unless configured to do so, whereas previously logging was all done by > log4net. > > I was thinking that I already have some wrapper classes to support > log4net, so I could make an additional project in the codebase to contain > this. Then by adjusting the nuget packages so there's a > "rhino.queues.core" package and a "rhino.queues" package (which depends on > rhino.queues.core and log4net) consumers should not be affected by the > change. The same approach would then apply to servicebus. > > Any thoughts on this? > > Thanks, > > Miles > > > > > > On Wednesday, June 13, 2012 4:26:05 PM UTC+1, Corey wrote: >> >> I'm tempted to just create a logging abstraction similar to the way >> Caliburn does and would be the least amount of change to the codebase and >> remove logging dependencies entirely. >> >> On Wed, Jun 13, 2012 at 4:38 AM, miles <[email protected]> wrote: >> >>> Hi, >>> >>> I was having some problems with ESB / Rhino.Queues in this regard - I'm >>> using the newer binaries in a project but need to integrate it with some >>> older code that is tied to the old log4net version, and so am getting lots >>> of binding failures. >>> >>> I've made a version of Queues using Common.Logging instead of log4net - >>> is the patch useful? >>> >>> Thanks, >>> >>> Miles >>> >>> >>> On Wednesday, January 25, 2012 4:23:40 PM UTC, Torkel Ödegaard wrote: >>>> >>>> Hi, >>>> >>>> Just thought I would notify you, if you are not already aware that due >>>> too a log4net nuget update on december 21st the Rhino Servicebus >>>> package is now broken. >>>> >>>> When installing latest Rhino.ServiceBus nuget package you also get >>>> installed log4net 1.2.11. >>>> >>>> Rhino ServiceBus / Rhino Queues 2.2.2 is compiled against log4net >>>> 1.2.10. Log4net 1.2.11 differ in PublicKeyToken so no assembly >>>> redirect will work. >>>> >>>> The Rhino.Queues nuget package does specify a version for its log4net >>>> dependecy, that is why nuget will take the latest version. >>>> >>>> Regards >>>> Torkel >>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Rhino Tools Dev" group. >>> To view this discussion on the web visit https://groups.google.com/d/** >>> msg/rhino-tools-dev/-/**WdjgSbUHS2wJ<https://groups.google.com/d/msg/rhino-tools-dev/-/WdjgSbUHS2wJ> >>> . >>> >>> To post to this group, send email to >>> rhino-tools-dev@googlegroups.**com<[email protected]> >>> . >>> To unsubscribe from this group, send email to >>> rhino-tools-dev+unsubscribe@**googlegroups.com<rhino-tools-dev%[email protected]> >>> . >>> For more options, visit this group at http://groups.google.com/** >>> group/rhino-tools-dev?hl=en<http://groups.google.com/group/rhino-tools-dev?hl=en> >>> . >>> >> >> -- > You received this message because you are subscribed to the Google Groups > "Rhino Tools Dev" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/rhino-tools-dev/-/7NFNUfxxv-8J. > > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/rhino-tools-dev?hl=en. > -- You received this message because you are subscribed to the Google Groups "Rhino Tools Dev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/rhino-tools-dev?hl=en.
