hi guys, thanks for your comments, i will work on the changes now and try to send them in the end of day.
BR Renato Filho On 9/1/05, Colin Walters <[EMAIL PROTECTED]> wrote: > On Thu, 2005-09-01 at 11:35 -0300, Renato Araujo wrote: > > Hi all, > > > > I finally had time to finish the initial podcast support for > > rhythmbox. Attached there are the diff against the CVS HEAD and a > > tarball with the new files. To test it just apply the patch and > > decompress the tarball inside your rhythmbox devel src dir. > > Please let me know what you think about it. Any doubt and suggestions > > are welcome. I will be glad to fix the bugs and add new features as > > needed. > > Ah...wow :) > > Ok. A bit busy at the moment, so I only had a chance to really glance > at the core diff. > > > + <schema> > > + <key>/schemas/apps/rhythmbox/state/podcast/search_text</key> > > I recently removed the saving of the search text to GConf from the other > sources, because it was totally confusing to users because no other app > does that. > > > + case RHYTHMDB_PROP_SUBTITLE: > > + ctx->entry->subtitle = rb_refstring_new > > (ctx->buf->str); > > + break; > > It would be nice if we could avoid adding stuff to the core > RhythmDBEntry, because that affects all types of entries like songs, and > I worry a bit about the memory impact. > > What some other pending sources like the daap source does is create hash > tables with their own data and watch entry-added/entry-deleted to keep > the hash tables in sync. I know it sucks...right now we don't have a > much better infrastructure. It's something I would like to work on, but > it has the potential to be seriously disruptive. > > I guess though we can just let this one go for now; say you have 10000 > songs, adding 6 pointers at 4 bytes each is 234k. We can just take the > hit on that until we have better infrastructure. > > > + PROP_PODCAST_SOURCE, > > The playlist manager doesn't seem to use this property? Longer term I > want to move to having the URI dispatching in the shell, so the playlist > manager shouldn't need to know about different sources. Really the > playlist manager's functionality should just be folded into the shell > proper, it's not that much code. > > Thanks for working on this! > > I'll have a look at your main patch tonight. > > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.2 (GNU/Linux) > > iD8DBQBDFzzzOIkJWWp2WGURAmujAJ0UHGTjSwGUi4Ba9/TbrVzQU2G90QCffIx/ > oV0VO2uj+A2gkGJYhvA5/4o= > =joMG > -----END PGP SIGNATURE----- > > > _______________________________________________ rhythmbox-devel mailing list [email protected] http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
