Hi, With all this UI talk, I wanted to submit a patch for
HIG: missing 12px border around entire UI http://bugzilla.gnome.org/show_bug.cgi?id=331789 which should be an easy fix... But adding a 12px border does definitely not work for primary windows which the HIG suggests for dialogs! http://developer.gnome.org/projects/gup/hig/2.0/design-window.html Look at the drag handle. http://www.fys.ku.dk/~maj/hig-12px_border.png When it comes to primary windows http://developer.gnome.org/projects/gup/hig/2.0/windows-primary.html the HIG doesn't mention anything about borders like they do for dialogs. I think this is a bug!? The screenshots in the HIG uses the Crux theme which have a small border, but not all themes have that. Example: http://www.fys.ku.dk/~maj/hig-no_border.png This makes Rhthmbox look very different from a theme that have a border. Example: http://www.fys.ku.dk/~maj/hig-border.png Most programs don't have a border, but to me this seams wrong. I would say the program should not be dependent on the theme. Gnome Dictionary have a border however to solve this: http://www.fys.ku.dk/~maj/hig-gnome_dictionary.png So, is this a bug in the HIG or Rhythmbox and most Gnome programs? =) Btw. For those who would like to play around with the Rhythmbox border you should look in rb-shell.c from line 1150 which look like vbox = gtk_vbox_new (FALSE, 0); gtk_container_set_border_width (GTK_CONTAINER (vbox), 12); gtk_box_pack_start (GTK_BOX (vbox), GTK_WIDGET (shell->priv->player_shell), FALSE, TRUE, 6); gtk_widget_show (GTK_WIDGET (shell->priv->player_shell)); gtk_box_pack_start (GTK_BOX (vbox), shell->priv->paned, TRUE, TRUE, 0); gtk_box_pack_start (GTK_BOX (vbox), GTK_WIDGET (shell->priv->statusbar), FALSE, TRUE, 0); gtk_widget_show (vbox); gtk_container_add (GTK_CONTAINER (win), vbox); _______________________________________________ rhythmbox-devel mailing list [email protected] http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
