I've attached two patches to the following bug: http://bugzilla.gnome.org/show_bug.cgi?id=343491
See comments below. On Fri, 2006-06-30 at 20:52 +0100, Peter wrote: > Hello list > > I've been looking at the Audioscrobbler plugin source code to see how it > handles the MusicBrainz ID or MBID tag: > > /rhythmbox/plugins/audioscrobbler/rb-audioscrobbler.c > > There is an AudioscrobblerEntry structure with a string field mbid, > which is used when writing to the queue and for submission's to last.fm > > However, as far as I can tell, the MBID field is never populated. Other > fields like the artist, title, length and timestamp get copied from > object audioscrobbler->priv which is a _RBAudioscrobblerPrivate structure. > > The _RBAudioscrobblerPrivate structure DOES NOT have an MBID field. Added in my audioscrobbler_mbid patch. > The other fields get updated by rb_audioscrobbler_song_changed_cb using > RHYTHMDB_PROP_TITLE, RHYTHMDB_PROP_ARTIST, RHYTHMDB_PROP_ALBUM, > RHYTHMDB_PROP_DURATION etc for the currently playing track. These > properties are defined in the enum RhythmDBPropType in: > > /rhythmbox/rhythmdb/rhythmdb.h > > There is currently no such entry for the MBID. I've added RHYTHMDB_PROP_MUSICBRAINZ_TRACKID, as well as RB_METADATA_MUSICBRAINZ_TRACKID in the musicbrainz_trackid patch. > Have I read the code correctly so far? If so I was wondering about > extending things... > > Some people might have the MBID in their mp3 ID3 tags from using some > analysis program (Picard, MusicTagger etc) so it would a good start if > rhythmbox could extract this field and pass it to the Audioscrobbler > plugin. [Should I file a "little" bug on just this?] > > Could the MBID track tag even be included in the database (what about > the album and artist tags if known?). In the musicbrainz_trackid patch, the track id is included in the database. You'll need to rebuild the database for it to be added. I'm currently working on a patch that will extract the track id from e.g. playing DAAP sources as well. Please provide feedback on the bug page (http://bugzilla.gnome.org/show_bug.cgi?id=343491) -- Ståle Lyngaas <[EMAIL PROTECTED]> _______________________________________________ rhythmbox-devel mailing list [email protected] http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
