Hi Anthony, Would you mind sending a pull request for the documentation updates without the protobuffs changes?
Regarding the protobuffs changes, it would be best to apply the changes to a fork of the basho/erlang_protobuffs repository and send a pull request. Regarding the buckets, they should be specified as binaries. I'll fix that now. Thanks, Dan Daniel Reverri Developer Advocate Basho Technologies, Inc. [email protected] On Fri, Jan 7, 2011 at 3:17 PM, Anthony Molinaro < [email protected]> wrote: > Hi, > > I recently forked riak-erlang-client to use the mainline erlang_protobuffs > (or at least a fork of it). In case any users out there are interested > here they are. > > https://github.com/djnym/riak-erlang-client > https://github.com/djnym/erlang_protobuffs > > So far they work great for me, and allow me to get the newly available > features > of erlang_protobuffs. > > I was also noticing some inconsistencies in the documentation of the client > which I fixed up (mostly that the put option is return_body, not > returnbody), > but also made a few other parts more consistent. > > However, I did notice one annoyance with the API which I was curious about. > For almost every example the bucket is passed as a binary, except for those > in the Bucket Properties section, where the bucket is passed as a string. > Is there a reason to not just make the riakc_pb_socket:get_bucket/2 and > riakc_pb_socket:set_bucket/3 calls take a binary like all the other calls? > > Just wondering, > > -Anthony > > -- > ------------------------------------------------------------------------ > Anthony Molinaro <[email protected]> > > _______________________________________________ > riak-users mailing list > [email protected] > http://lists.basho.com/mailman/listinfo/riak-users_lists.basho.com >
_______________________________________________ riak-users mailing list [email protected] http://lists.basho.com/mailman/listinfo/riak-users_lists.basho.com
