[
https://issues.jboss.org/browse/RF-11723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644970#comment-12644970
]
Karsten Wutzke edited comment on RF-11723 at 11/22/11 9:50 PM:
---------------------------------------------------------------
Note the ruby (datatable) gradient should go from dark rosé to red (top to
bottom) as in RF 3.
was (Author: kwutzke):
Note the ruby gradient should go from dark rosé to red (top to bottom) as
in RF 3.
> Datatable sub headers wrong colors (gradient) and datascoller buttons wrong
> color (gradient) plus more skinning issues (classic + ruby)
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: RF-11723
> URL: https://issues.jboss.org/browse/RF-11723
> Project: RichFaces
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: base functionality , skinning
> Affects Versions: 4.0.0.Final, 4.1.0.Milestone1, 4.1.0.Milestone2,
> 4.1.0.Milestone3, 4.1.0.Milestone4, 4.1.0.CR1
> Reporter: Karsten Wutzke
> Labels: classic, datascroller, datatable, ecss, ruby, skinning
>
> Please see this unanswered forum post:
> http://community.jboss.org/thread/173083
> and an older one: http://community.jboss.org/thread/165584
> I looked into
> richfaces-components-ui-<version>/META-INF/resources/org.richfaces/datatable.ecss
> and found:
> .rf-dt-shdr-c {
> border-bottom-width: '#{richSkin.tableBorderWidth}';
> border-bottom-style: solid;
> border-bottom-color: '#{richSkin.tableBorderColor}';
> border-right-width: '#{richSkin.tableBorderWidth}';
> border-right-style: solid;
> border-right-color: '#{richSkin.tableBorderColor}';
> background-color: '#{richSkin.tableHeaderBackgroundColor}';
> background-image:
> "url(#{resource['org.richfaces.images:colHdrGrad.png']})";
> background-position: top left;
> color: '#{richSkin.tableHeaderTextColor}';
> font-family: '#{richSkin.generalFamilyFont}';
> font-size: '#{richSkin.generalSizeFont}';
> font-weight: bold;
> padding: 4px;
> text-align: center;
> }
> The above is wrong. First of all there shouldn't be a gradient on the
> subheader cells, so background-image and background-position should be
> deleted. Second the text color is wrong, so the value should change from
> color: '#{richSkin.tableHeaderTextColor}' to color:
> '#{richSkin.generalTextColor}', also see the font properties below referring
> to general.
> The same holds true for
> richfaces-components-ui-<version>/META-INF/resources/org.richfaces/datascroller.ecss:
> .rf-ds-btn {
> cursor: pointer;
> padding: 2px 10px 3px 10px;
> border-width: 1px;
> border-style: solid;
> border-color: '#{richSkin.tableBorderColor}';
> display: inline-block;
> background-position: top left;
> background-repeat: repeat-x;
> background-color: '#{richSkin.headerBackgroundColor}';
> background-image:
> "url(#{resource['org.richfaces.images:dsBtnGrad.png']})";
> font-size: '#{richSkin.generalSizeFont}';
> font-family: '#{richSkin.generalFamilyFont}';
> color: '#{richSkin.generalTextColor}';
> text-decoration: none;
> font-weight: normal;
> }
> The rf-ds-* buttons of all kinds shouldn't have a gradient on them so
> background-image and background-position should be deleted as well. Again,
> please see the RF 3 and RF 4 demos to compare the colors (see my forum post
> for direct links).
> Note there might be a number of other components with the same problem. I've
> checked only datatable.ecss and datascroller.ecss so far. It would be nice to
> update the RF 4 showcase to again include the (fixed) table header and table
> sub header colors to show up in different colors.
> Note two skin-specific things:
> 1. classic: the default sub header cell is too dark, the table borders seem
> to disappear visually.
> 2. ruby: the default gradient is different from the other RF 4 gradient
> components, e.g. panel headers. Datatables placed on the GUI kind of look
> "alien", because they don't fit with the other gradients. It should be red to
> rosé, not dark rosé to bright rosé.
> Again, there are probably more skin-specific color issues, but I can't check
> more right now. The above were the most serious ones I've found when
> switching from RF 3 to RF 4.
> (Sorry for flagging this as major, but there are a number of people out there
> who care about these things - like myself - and I'd like to have these fixed
> in 4.1.0.Final if possible!)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
richfaces-issues mailing list
richfaces-issues@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/richfaces-issues
