[ 
https://issues.jboss.org/browse/RF-12662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brian Leathem resolved RF-12662.
--------------------------------

    Resolution: Done


Added a FacesMessage when the filter expression evaluation fails
                
> Showcase - rich:extendedDataTable - Built-in sorting and filtering - 
> ELException when text filter value provided instead of expected numbers
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: RF-12662
>                 URL: https://issues.jboss.org/browse/RF-12662
>             Project: RichFaces
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: component-tables, showcase
>    Affects Versions: 4.3.0.M3
>         Environment: showcase M3 release
>            Reporter: Juraj Húska
>            Assignee: Brian Leathem
>            Priority: Minor
>             Fix For: 4.3.0.CR1
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> When providing characters as filter value for column Price instead of numbers 
> , an ELException is thrown on the the server console:
> {code}
> 14:59:21,603 SEVERE [org.richfaces.log.Context] (http--0.0.0.0-8080-4) 
> javax.el.ELException: 
> /richfaces/extendedDataTable/samples/edt-builtin-sorting-and-filtering-sample.xhtml
>  @38,75 filterValue="#{carsFilteringBean.mileageFilter}": Cannot convert gg 
> of type class java.lang.String to class java.lang.Long: 
> javax.faces.FacesException: javax.el.ELException: 
> /richfaces/extendedDataTable/samples/edt-builtin-sorting-and-filtering-sample.xhtml
>  @38,75 filterValue="#{carsFilteringBean.mileageFilter}": Cannot convert gg 
> of type class java.lang.String to class java.lang.Long
>       at 
> org.richfaces.renderkit.SortingFilteringRowsRenderer.updateAttribute(SortingFilteringRowsRenderer.java:144)
>  [richfaces-components-ui-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at 
> org.richfaces.renderkit.SortingFilteringRowsRenderer.decodeFiltering(SortingFilteringRowsRenderer.java:84)
>  [richfaces-components-ui-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at 
> org.richfaces.renderkit.SortingFilteringRowsRenderer.decodeSortingFiltering(SortingFilteringRowsRenderer.java:62)
>  [richfaces-components-ui-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at 
> org.richfaces.renderkit.ExtendedDataTableRenderer.doDecode(ExtendedDataTableRenderer.java:945)
>  [richfaces-components-ui-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at org.richfaces.renderkit.RendererBase.decode(RendererBase.java:80) 
> [richfaces-components-ui-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at 
> javax.faces.component.UIComponentBase.decode(UIComponentBase.java:787) 
> [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
>       at 
> org.richfaces.component.UIDataAdaptor.processDecodes(UIDataAdaptor.java:820) 
> [richfaces-components-ui-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at 
> org.richfaces.context.PartialViewExecuteVisitCallback.visit(PartialViewExecuteVisitCallback.java:53)
>  [richfaces-core-impl-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at 
> org.richfaces.context.BaseExtendedVisitContext.invokeVisitCallback(BaseExtendedVisitContext.java:321)
>  [richfaces-core-impl-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at 
> org.richfaces.component.UIDataAdaptor.visitTree(UIDataAdaptor.java:1320) 
> [richfaces-components-ui-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at javax.faces.component.UIComponent.visitTree(UIComponent.java:1623) 
> [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
>       at javax.faces.component.UIForm.visitTree(UIForm.java:371) 
> [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
>       at javax.faces.component.UIComponent.visitTree(UIComponent.java:1623) 
> [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
>       at javax.faces.component.UIComponent.visitTree(UIComponent.java:1623) 
> [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
>       at 
> org.richfaces.context.ExtendedPartialViewContextImpl.executeComponents(ExtendedPartialViewContextImpl.java:237)
>  [richfaces-core-impl-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at 
> org.richfaces.context.ExtendedPartialViewContextImpl.processPartialExecutePhase(ExtendedPartialViewContextImpl.java:217)
>  [richfaces-core-impl-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at 
> org.richfaces.context.ExtendedPartialViewContextImpl.processPartial(ExtendedPartialViewContextImpl.java:196)
>  [richfaces-core-impl-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:931) 
> [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
>       at 
> com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestValuesPhase.java:78)
>  [jsf-impl-2.1.7-jbossorg-2.jar:]
>       at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101) 
> [jsf-impl-2.1.7-jbossorg-2.jar:]
>       at 
> com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118) 
> [jsf-impl-2.1.7-jbossorg-2.jar:]
>       at 
> org.richfaces.demo.arrangeablemodel.PersistenceLifecycle.execute(PersistenceLifecycle.java:58)
>  [classes:]
>       at javax.faces.webapp.FacesServlet.service(FacesServlet.java:593) 
> [jboss-jsf-api_2.1_spec-2.0.1.Final.jar:2.0.1.Final]
>       at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:329)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.jboss.weld.servlet.ConversationPropagationFilter.doFilter(ConversationPropagationFilter.java:62)
>  [weld-core-1.1.5.AS71.Final.jar:2012-02-10 15:31]
>       at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.ocpsoft.rewrite.servlet.RewriteFilter.doFilter(RewriteFilter.java:172) 
> [rewrite-servlet-1.0.4.Final.jar:1.0.4.Final]
>       at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:248)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:275)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:161)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.jboss.as.jpa.interceptor.WebNonTxEmCloserValve.invoke(WebNonTxEmCloserValve.java:50)
>  [jboss-as-jpa-7.1.1.Final.jar:7.1.1.Final]
>       at 
> org.jboss.as.web.security.SecurityContextAssociationValve.invoke(SecurityContextAssociationValve.java:153)
>  [jboss-as-web-7.1.1.Final.jar:7.1.1.Final]
>       at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:155) 
> [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) 
> [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:368) 
> [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:877) 
> [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:671)
>  [jbossweb-7.0.13.Final.jar:]
>       at 
> org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:930) 
> [jbossweb-7.0.13.Final.jar:]
>       at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_05]
> Caused by: javax.el.ELException: 
> /richfaces/extendedDataTable/samples/edt-builtin-sorting-and-filtering-sample.xhtml
>  @38,75 filterValue="#{carsFilteringBean.mileageFilter}": Cannot convert gg 
> of type class java.lang.String to class java.lang.Long
>       at 
> com.sun.faces.facelets.el.TagValueExpression.setValue(TagValueExpression.java:139)
>  [jsf-impl-2.1.7-jbossorg-2.jar:]
>       at 
> org.richfaces.renderkit.SortingFilteringRowsRenderer.updateAttribute(SortingFilteringRowsRenderer.java:142)
>  [richfaces-components-ui-4.3.0.20121214-M3.jar:4.3.0.20121214-M3]
>       ... 42 more
> {code}
> IMHO {{rich:message}} should be placed there to warn user about incorrect 
> input and the exception should be handled.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

_______________________________________________
richfaces-issues mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/richfaces-issues

Reply via email to