[ 
https://issues.jboss.org/browse/RF-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Juraj Húska closed RF-13480.
----------------------------



Verified.

Only one point, {{util}} package remained, however, it contain now 
{{converters}}. Reopen the issue if you insist on renaming the util package 
completely. IMHO it is fine now.
                
> Java package re-structure for the photoalbum demo
> -------------------------------------------------
>
>                 Key: RF-13480
>                 URL: https://issues.jboss.org/browse/RF-13480
>             Project: RichFaces
>          Issue Type: Enhancement
>      Security Level: Public(Everyone can see) 
>          Components: examples
>            Reporter: Brian Leathem
>            Assignee: Michal Petrov
>              Labels: photoalbum
>             Fix For: 4.3.5
>
>   Original Estimate: 2 hours
>  Remaining Estimate: 2 hours
>
> This issue addresses the cleanup of the java package namespace of the demo.
> 1) The package _org.richfaces.photoalbum.bean_ contains the single class 
> _UserBean_.  Let's rename the package to something less generic like _user_ 
> or consider merging it into another pre-existing package like _ui_.
> 2) The _event_ package is separate from the _domain_ package.  Let's consider 
> moving the _event_ package to be a sub-package of _domain_.  While we are at 
> it, I find the package name _model_ to be more descriptive than _domain_.
> 3) The _services_ package may be better described as an _actions_ package.
> 4) The _util_ package is too generic.  Consider creating _converters_ and 
> _validators_ packages to hold the bulk of these classes.  Additionally the 
> classnames _*Stuff_ and _Utils_ could be named less generically.
> 5) having the two top-level classes _search_ and _ejbsearch_ is confusing.  
> Can one package be a sub-folder of the other?  Alternatively could one be in 
> the _ui_ folder, or the other in a _model_ folder?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

_______________________________________________
richfaces-issues mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/richfaces-issues

Reply via email to