Hi Eddy,
thanks a lot for implementing this!
The implementation itself looks solid and you located the correct
areas in the repository where to make the changes.
I looked at it and have some remarks:
* you forgot to include some files in the patch (mostly exceptions,
check with svn status, you probably didn't add them to the repository)
* you did test the SubmissionBuilder, but you didn't implement any
functional tests in TestEngineSubmissions
After these changes I will commit the patch to the repository.
Best regards,
Geert
On 15 Jun 2006, at 17:20, Eddy Young wrote:
All,
I have implemented the enhancement logged under bug RIFE-270 in
JIRA. Grateful if any could include the proposed patch in their
copy of RIFE source and run the unit tests. This would remove the
burden from Geert and allow us to address more issues/requests.
I am waiting for feedback before I move on to implementing another
issue.
Regards,
Eddy
--
http://coding.mu
http://priscimon.com/blog
_______________________________________________
Rife-users mailing list
Rife-users@uwyn.com
http://lists.uwyn.com/mailman/listinfo/rife-users
--
Geert Bevin
Uwyn "Use what you need" - http://uwyn.com
RIFE Java application framework - http://rifers.org
Music and words - http://gbevin.com
_______________________________________________
Rife-users mailing list
Rife-users@uwyn.com
http://lists.uwyn.com/mailman/listinfo/rife-users
