michael123;510604 Wrote: 
> Ronald
> 
> I found the issue you were mentioning:
> 
> in file sox.c, routine calculate_output_signal_parameters()
> 
> there are these funny lines:
> 
> > 
Code:
--------------------
  >   > 
  > /* FIXME: comment this: */
  > ofile->signal.precision = combiner_signal.precision;
  > 
--------------------
> > 
> 
> "funny" because combiner_signal is the precision of the input files,
> i.e. 16-bit. And sox just ignored whatever we pass via command line
> 
> I suggest changing these to
> 
> > 
Code:
--------------------
  >   > 
  > ofile->signal.precision = ofile->encoding.bits_per_sample;
  > 
--------------------
> > 
> 
> Anyway, your workaround looks like working just fine.
> I fixed (?) the bug and have my private copy (for Windows)
Hello Michael,

Great you found it and even greater that you have a fix :-)
I'll recompile 14.3 as well using you fix and then soon do a test to
see if the polyphase substitution will sound the same as the real
"obsolete" thing ;-)

I am also curious, do you here an improvement now with your fix
applied?

Ronald


-- 
tingtong5
------------------------------------------------------------------------
tingtong5's Profile: http://forums.slimdevices.com/member.php?userid=9671
View this thread: http://forums.slimdevices.com/showthread.php?t=69454

_______________________________________________
ripping mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/ripping

Reply via email to