>> Simple bug: even if configure correctly spots that we don't have >> libflac, rdwavefile.cpp contains unguarded FLAC_ types, so the build dies. > Got some specifics on this (version, line numbers)? Some quick tests with > current CVS-Head shows no problems. > Sure, sorry it took me a bit to get around to reproducing. The problem is that libsndfile is required, and at least on Ubuntu Lucid that pulls in some libFLAC headers (specifically libsndfile1-dev pulls libflac-dev). However to actually build FLAC encoding support I'd also need libflac++-dev. Without that package, configure ends up defining HAVE_FLAC_METADATA but not HAVE_FLAC, and rdwavefile.cpp compile dies with:
rdwavefile.cpp: In member function 'void RDWaveFile::ReadFlacMetadata()': rdwavefile.cpp:3610: error: 'FLAC__StreamMetadata' was not declared in this scope rdwavefile.cpp:3610: error: 'tags' was not declared in this scope rdwavefile.cpp:3612: error: 'FLAC__metadata_get_tags' was not declared in this scope rdwavefile.cpp:3618: error: 'FLAC__StreamMetadata_VorbisComment_Entry' was not declared in this scope rdwavefile.cpp:3619: error: 'comment' was not declared in this scope rdwavefile.cpp:3677: error: 'FLAC__metadata_object_delete' was not declared in this scope I'd suggest that !HAVE_FLAC should imply !HAVE_FLAC_METADATA. Chris _______________________________________________ Rivendell-dev mailing list [email protected] http://lists.rivendellaudio.org/mailman/listinfo/rivendell-dev
